Skip to content

Tony/366 template app oidc#368

Open
tonypioneer wants to merge 1 commit into
devfrom
tony/366_template_app_oidc
Open

Tony/366 template app oidc#368
tonypioneer wants to merge 1 commit into
devfrom
tony/366_template_app_oidc

Conversation

@tonypioneer

Copy link
Copy Markdown
Collaborator

Pull Request Details

Description

Added Solid OIDC client configuration constants to SolidUI template app.

Related Issues

#366

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How To Test?

Run dart run solidui:create my_pod_app to generate a new app and check the relevant constants in lib/constants/app.dart

Checklist

  • Screenshots included here/in linked issue #
  • Changes adhere to the style and coding guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • The update contains no confidential information
  • The update has no duplicated content
  • No lint check errors are related to these changes (make prep or flutter analyze lib)
  • Integration test dart test output or screenshot included in issue #
  • I tested the PR on these devices:
    • Android
    • iOS
    • Linux
    • MacOS
    • Windows
    • Web
  • I have identified reviewers
  • The PR has been approved by reviewers

Finalising

  • Merge dev into the this branch
  • Resolve any conflicts
  • Add a one line summary into the CHANGELOG.md
  • Push to the git repository and review
  • Merge the PR into dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SOLIDUI: The SolidUI template app code does not include the required constants for the Solid OIDC client configuration

1 participant